Closed bubble75 closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
collector/crm_mon.go | 0 | 14 | 0.0% | ||
<!-- | Total: | 0 | 14 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 17: | 0.0% |
Covered Lines: | 42 |
Relevant Lines: | 1724 |
Hi @bubble75 ,
Can you please put here an example of how it looks like before and after the change?
Now it looks like (metrics are synthetic):
pacemaker_resource_active{group_id="mygroup",id="group_res1",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_resource_active{group_id="mygroup",id="group_res2",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_resource_active{clone_id="myclone",id="clone_res",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_resource_active{id="myres",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
Before this PR output was:
pacemaker_group_resource_active{group_id="mygroup",id="group_res1",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_group_resource_active{group_id="mygroup",id="group_res2",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_clone_resource_active{clone_id="myclone",id="clone_res",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1 pacemaker_resource_active{id="myres",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
@bubble75 Thanks for contributing!
Otherwise it is very hard to get overall picture on resources states - both groups and clones may not present in a given cluster, making it very hard to do arithmetics with NA vectors in prometheus.