mjtrangoni / pacemaker_exporter

Prometheus exporter for Pacemaker high availability resource manager
Apache License 2.0
9 stars 7 forks source link

Unify metrics names #6

Closed bubble75 closed 4 years ago

bubble75 commented 4 years ago

Otherwise it is very hard to get overall picture on resources states - both groups and clones may not present in a given cluster, making it very hard to do arithmetics with NA vectors in prometheus.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 18


Changes Missing Coverage Covered Lines Changed/Added Lines %
collector/crm_mon.go 0 14 0.0%
<!-- Total: 0 14 0.0% -->
Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 42
Relevant Lines: 1724

💛 - Coveralls
mjtrangoni commented 4 years ago

Hi @bubble75 ,

Can you please put here an example of how it looks like before and after the change?

bubble75 commented 4 years ago

Now it looks like (metrics are synthetic):

pacemaker_resource_active{group_id="mygroup",id="group_res1",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_resource_active{group_id="mygroup",id="group_res2",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_resource_active{clone_id="myclone",id="clone_res",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_resource_active{id="myres",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1

Before this PR output was:

pacemaker_group_resource_active{group_id="mygroup",id="group_res1",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_group_resource_active{group_id="mygroup",id="group_res2",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_clone_resource_active{clone_id="myclone",id="clone_res",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
pacemaker_resource_active{id="myres",node_name="node01",resource_agent="ocf::pacemaker:Dummy",role="Started",target_role="Started"} 1
mjtrangoni commented 4 years ago

@bubble75 Thanks for contributing!