search

mjul / docjure

Read and write Office documents from Clojure
MIT License
622 stars 129 forks source link

Fix reflection warnings on spreadsheet namespace evaluation #100

Closed dannyfreeman closed 2 years ago

dannyfreeman commented 2 years ago

When the spreadsheet namespace is evaluated I get two reflection warnings printed out to my console

Reflection warning, dk/ative/docjure/spreadsheet.clj:705:17 - call to org.apache.poi.ss.util.CellReference ctor can't be resolved.
Reflection warning, dk/ative/docjure/spreadsheet.clj:579:42 - call to method getFormat on org.apache.poi.ss.usermodel.DataFormat can't be resolved (argument types: java.lang.Object).

This PR will resolve both warnings. More details are in the commit messages. All the tests pass locally for me. Let me know if there is anything I might need to do.

mjul commented 2 years ago

Thanks a lot for your contribution. I will add you to the contributors list.

dannyfreeman commented 2 years ago

Thank you!!!