mjul / docjure

Read and write Office documents from Clojure
MIT License
622 stars 129 forks source link

Select a sheet from a workbook using a regex #18

Closed jonneale closed 10 years ago

jonneale commented 10 years ago

Hi, thanks for a great library! We are commonly sent workbooks with consistent sheet names but different casing of those names and different sheet ordering, making it hard to select the required sheet. This change adds a public function that allows the specification of a regex to find a sheet by name

mjul commented 10 years ago

Hi Jon,

thanks a lot for the patch. It is a great idea.

Now that we are at it, I am thinking could be generalized to arbitrary predicates. Would this be a good case for a multi method overloading of the select-sheet function the class of the its first parameter to three cases:

Let me know what you think, and if you like it I will happily accept a patch with the multi method implementation.

Thanks a lot for you help.

Martin

jonneale commented 10 years ago

Hi Martin

I agree, that would be a really useful feature. I've pushed an implementation. Let me know what you think

Thanks again

Jon