mjul / docjure

Read and write Office documents from Clojure
MIT License
622 stars 129 forks source link

Date base is taken into account for date formulas #25

Closed nidu closed 9 years ago

nidu commented 9 years ago

Date base (1900 or 1904) wasn't taken into account in read-cell for formula date cells. Now it's fixed. read-cell-value for Cell/CELL_TYPE_NUMERIC doesn't use date-format? internally, but isn't removed to save backward compatibility. Moreover workbook method that can show if workbook uses 1904 base date (e.g. XSSFWorkbook.isDate1904) is protected and thus can't be used without inheritance or dirty hacks AFAIK. However read-cell-value itself doesn't consider date base as it isn't present in cell value and requires changing method args.

P.S.: test files sizes are smaller probably because thumbnails are not included.