search

mjul / docjure

Read and write Office documents from Clojure
MIT License
619 stars 129 forks source link

Upgrade to Apache POI 4.0 #78

Closed mjul closed 4 years ago

mjul commented 5 years ago

The Apache POI project used by Docjure has released version 4.0.0. Docjure should be upgraded from the 3.x series to use the latest version. Read about Apache POI here: http://poi.apache.org

manuelherzog commented 5 years ago

Hey,

right now i'm doing the migration, as i need the newer version for other POI tasks and libs.

I'm getting to multiple problems before i could start, lein test did not run because the Classloader was not found. I updated pomegranate and then get the error that there is no writeable Classloader anymore. Then i removed that one test that was failing because it can't add the test-data to the classpath.

I upgraded to POI 4.0.1 and it works quite easily.

But, now i get the exception "Truncated ZIP file" on one test only. Rolled back and noticed that the stream that was written to was not closed properly.

Sending you the pull request with 3 commits, if you want to fix the two problems not directly attached to the migration in another way

Best Manuel PR #81

mjul commented 4 years ago

Thanks for this and the PR. It has already been merged, so I am closing this.