mjul
commented
2 years ago Thank you very much for this update, I have merged it and I will add you to the contributors list.
You make a good point about the breaking changes in the underlying POI APIs, I will make a note of it in the CHANGELOG document. I am not going to bump the major version since the changes are not breaking for people using only the Docjure spreadsheet API.
This moves the project to Apache POI 5.2.2, this will prevent this library from being flagged by vulnerability scans. I have to get this done as the project I work on needs to meet certain compliance requirements.
The code changes were minor but it's important to note that there are some changes from the Apache POI project that will effect consumers of this library, this is not a drop-in replacement. For instance, the POI project has eliminated (AFAICT) all of the "Enum" methods (i.e. getBorderBottomEnum, getFillPatternEnum, etc.) This isn't a huge deal, the "Enum"-less methods work the same (getBorderBottom, getFillPattern). But code that depends on these methods being present will fail.
In terms of merging and releasing this code, it may make sense to bump a major version to hint to consumers that there are breaking changes.