mjvotaw / plex-sub-downloader

An attempt to build a simple command-line tool for automating the adding of subtitles to Plex content.
MIT License
13 stars 3 forks source link

Meaning of "Found 0 videos missing subtitles" #2

Closed sasagr closed 1 year ago

sasagr commented 1 year ago

Is this happening because the file has already embedded subtitles? If this is the case can we have the option to add the external subtitles anyway?

2022-10-27 12:32:27:PlexSubDownloader:INFO - Handling library.new event 2022-10-27 12:32:27:PlexSubDownloader:INFO - Title: The Peripheral, type: show, section: TV Shows 2022-10-27 12:32:29:PlexSubDownloader:INFO - Found 0 videos missing subtitles 2022-10-27 12:32:29:PlexSubDownloader:INFO - [] 2022-10-27 12:32:29:PlexSubDownloader:INFO - No subtitles to download, doing nothing! 192.168.1.18 - - [27/Oct/2022 12:32:29] "POST /webhook HTTP/1.1" 200 -

sasagr commented 1 year ago

added a "fake" movie video but I got the same result. Any idea?

2022-10-27 13:03:02:PlexSubDownloader:INFO - Handling library.new event 2022-10-27 13:03:02:PlexSubDownloader:INFO - Title: Wild Wild West, type: movie, section: Movies extra 2022-10-27 13:03:24:PlexSubDownloader:INFO - Found 0 videos missing subtitles 2022-10-27 13:03:24:PlexSubDownloader:INFO - [] 2022-10-27 13:03:24:PlexSubDownloader:INFO - No subtitles to download, doing nothing!

sasagr commented 1 year ago

I did a few tests and it worked one time, then I deleted the movie, re-added it to test again and this time it did not work.

2022-10-27 13:49:45:PlexSubDownloader:INFO - Handling library.new event 2022-10-27 13:49:45:PlexSubDownloader:INFO - Title: The Mountain Road, type: movie, section: Movies 2022-10-27 13:49:46:PlexSubDownloader:INFO - Found 1 videos missing subtitles 2022-10-27 13:49:46:PlexSubDownloader:INFO - ['The Mountain Road, /library/metadata/9326'] 2022-10-27 13:49:46:PlexSubDownloader:INFO - Downloading subtitles for 1 videos 2022-10-27 13:49:46:PlexSubDownloader:INFO - ['The Mountain Road'] 2022-10-27 13:49:48:PlexSubDownloader:INFO - Saving subtitles to Plex metadata 2022-10-27 13:49:48:PlexSubDownloader:INFO - found 1 for video /mnt/REDEB/movies/The.Mountain.Road.1960.1080p.WEBRip.x265-RARBG/The.Mountain.Road.1960.1080p.WEBRip.x265-RARBG.mp4 192.168.1.18 - - [27/Oct/2022 13:49:48] "POST /webhook HTTP/1.1" 200 - 192.168.1.18 - - [27/Oct/2022 13:50:33] "POST /webhook HTTP/1.1" 200 - 192.168.1.18 - - [27/Oct/2022 13:52:15] "POST /webhook HTTP/1.1" 200 - 2022-10-27 13:55:49:PlexSubDownloader:INFO - Handling library.new event 2022-10-27 13:55:49:PlexSubDownloader:INFO - Title: The Peripheral, type: show, section: TV Shows 2022-10-27 13:55:50:PlexSubDownloader:INFO - Found 0 videos missing subtitles 2022-10-27 13:55:50:PlexSubDownloader:INFO - [] 2022-10-27 13:55:50:PlexSubDownloader:INFO - No subtitles to download, doing nothing! 192.168.1.18 - - [27/Oct/2022 13:55:50] "POST /webhook HTTP/1.1" 200 - 2022-10-27 13:57:41:PlexSubDownloader:INFO - Handling library.new event 2022-10-27 13:57:41:PlexSubDownloader:INFO - Title: The Mountain Road, type: movie, section: Movies 2022-10-27 13:57:43:PlexSubDownloader:INFO - Found 0 videos missing subtitles 2022-10-27 13:57:43:PlexSubDownloader:INFO - [] 2022-10-27 13:57:43:PlexSubDownloader:INFO - No subtitles to download, doing nothing!

ghost commented 1 year ago

Hey, thanks for giving this project a try, and sorry for not checking this for, apparently, months.

To your first question: You're correct, this does check for embedded subtitles. I'm not sure if I can differentiate between embedded and non-embedded subtitles. I haven't touched this project in several months, and my brain has forgotten pretty much everything about it.

And the second: The reason why you got Found 0 videos missing subtitles when you re-added The Mountain Road is (probably) because of how Plex handles uploaded subtitles. If you have the subtitle_destination config option set to "metadata", Plex saves it as part of the media's metadata, and that metadata maybe hadn't been deleted yet.

If you've got subtitle_destination set to "with_media" and this still happened, then I have no idea, and would need to look into it.

sasagr commented 1 year ago

It was on metadata and I think you are right. I did not have this issue anymore