mjwestgate / revtools

Tools to support research synthesis in R
https://revtools.net
48 stars 26 forks source link

Excluded articles still appearing in plotly graphic #18

Closed Joemillard closed 5 years ago

Joemillard commented 5 years ago

It would be a pretty significant improvement if excluded articles were excluded from ordination space following recalculation. After rerunning the model, excluded articles are only indicated as such once selected in "selected text". To me it seems more intuitive if these articles were to be removed from the plot, or at least still indicated as greyed out dots to avoid re-examining the same article. Also it's not totally clear to me whether excluding an article from ordination space also excludes it from the reactiveValue object fed to the topic classifier models in any subsequent calculations. If articles were removed from ordination space in recalculations it would at least be more explicit that these articles are now not influencing the output.

mjwestgate commented 5 years ago

Hi Joe - as with your other comment this is what revtools is supposed to do; the behaviour you observed appears to be a bug. When articles or topics are excluded they should be greyed out, while 'selected' articles or topics should turn black. Finally, all excluded articles should be missing when you recalculate your topic model. If this isn't happening then let me know and I'll recheck.