search

mjxu96 / carlaviz

Visualize carla in the web browser
MIT License
258 stars 60 forks source link

Docker setup in dockerfile #29

Closed wuhanstudio closed 3 years ago

wuhanstudio commented 3 years ago

Hi,

After removing build cache from previous docker layers, I notice that the only thing it does in docker_setup.sh is yarn build.

Perhaps it's better to put it in the Dockerfile, so that all docker related setup can be found in a single folder.

mjxu96 commented 3 years ago

Thanks @wuhanstudio. Let me merge it.