search

mjxu96 / carlaviz

Visualize carla in the web browser
MIT License
264 stars 61 forks source link

Libcarla as submodule #45

Closed umateusz closed 1 year ago

umateusz commented 3 years ago

Hey, I have prepared a version where libcarla is a submodule. It will be easier to change libcarla and compare carlaviz repo changes. What do you think?

mjxu96 commented 3 years ago

Hi @umateusz , I considered this before but I don't think this is a good idea. Here are my reasons.

  1. Carla's official repo has too many unrelated things/codes. Some of them belong to the server side or Unreal Engine side. Including all of them will bring messy stuffs to this repo.
  2. When carla upgrades, we may still need to change some bash scripts, like setup.sh in this repo. So why not copying the LibCarla codes as well?
mjxu96 commented 3 years ago

Hi @umateusz , I considered this before but I don't think this is a good idea. Here are my reasons.

  1. Carla's official repo has too many unrelated things/codes. Some of them belong to the server side or Unreal Engine side. Including all of them will bring messy stuffs to this repo.
  2. When carla upgrades, we may still need to change some bash scripts, like setup.sh in this repo. So why not copying the LibCarla codes as well?
umateusz commented 2 years ago

Hi @mjxu96.

Having libcarla as a submodule will make it easier to change version and control it. Currently, we cannot check which version of carlaviz works.

  1. I agree that It would be better to download libcarla without any additional dependencies but that would require some extra work on Carla side. I think it's better to download too much than copy the code.
  2. If we need any code changes, it's better to do them on the Carla side. If there are small changes to e.g. setup.sh, only this file can be copied.

It's your decision, if you think it's better to copy the code please close this PR.

yuijim commented 2 years ago

Hi all,

I think there is a solution somewhere in between of including whole CARLA sources as a submodule (which I agree could get quite messy) and copying the LibCarla code. Why not add downloading & extracting LibCarla sources as a part of setup.sh, the way other libs are added? It seemed to work quite well in our quick-and-dirty upgrade to 0.9.13 (https://github.com/wielgosz-info/carlaviz/commit/797fa93fe075616c139ecea1d79bb5e28914dc4a#diff-d32ba621b1d068eebb89e2404a5da195eafb40d58ee9f5c9d542a18a9cc6b35a). It allows both to avoid the overhead of checking out the whole carla repo history & ensures the carlaviz versioning is for a specific version of CARLA.

@mjxu96, do you think something like that could work?

mjxu96 commented 1 year ago

I will use Conan to manage the dependency in this PR https://github.com/mjxu96/carlaviz/pull/62

Thanks for the PR and thoughts.