search

mk-fg / python-pulse-control

Python high-level interface and ctypes-based bindings for PulseAudio (libpulse)
https://pypi.org/project/pulsectl/
MIT License
170 stars 36 forks source link

tests: remove all.py and update README accordingly #56

Closed sbraz closed 3 years ago

sbraz commented 3 years ago

I also removed the call to unittest.main() which didn't really seem necessary, let me know if that is OK.

Please don't merge this right now. I'd like to add some basic GitHub hooks to run the tests (if you're interested, of course).

mk-fg commented 3 years ago

Updated it in the repo at roughly same time after last PR. Needed to bump version and run twine anyway.

sbraz commented 3 years ago

That was fast :) Are you still interested in adding basic CI with GitHub actions?

mk-fg commented 3 years ago

Not really. It seem to be trivial to run tests manually here, so why bother and add extra complexity and annoyance :)

sbraz commented 3 years ago

Do you test all Python versions locally? I find GH actions really easy to use. It's just 22 lines in one file and you can test basically all Python versions :) https://github.com/sbraz/python-pulse-control/runs/2559772306 (apparently Python 3.5 is broken, perhaps you should remove it from setup.py) See the code here: https://github.com/mk-fg/python-pulse-control/compare/master...sbraz:actions?expand=1

mk-fg commented 3 years ago

Do you test all Python versions locally?

No, usually just run tests with ones that I have installed here. Aside from really old versions like 3.5 which don't really matter, don't think it should be a problem, at least while python2 support is around to scare new syntax away.

It's just 22 lines in one file and you can test basically all Python versions :)

Yeah, and then it'll get broken like these seem to be in most projects which I sent PRs to. Also don't think code in PRs should be correct or even run to be useful, and kinda same for pushes.

Can see why it might be more useful in a larger project where people can't keep track of all parts anymore or to help with the incoming contribution traffic if it's too high, but don't think these apply here.