search

mk-minchul / AdaFace

MIT License
665 stars 122 forks source link

the 18th formula with AdaFace function that are inconsistent #10

Closed eeric closed 2 years ago

eeric commented 2 years ago

the 18th formula in paper is inconsistent with AdaFace code

mk-minchul commented 2 years ago

Dear eeric. Thanks for pointing out. The scaling term s in equation 18 should be multiplied after all the margin is applied, so it is missing a paranthesis. i.e: s(cos(theta_j+g_angle)- g_add) The code is implemented as intended.

eeric commented 2 years ago

yes, good.