Various suggestions

[asarhaddon]

Hello. This merge request mixes a few subjects, but I only expect the fourth commit to contain controversial changes (I am not sure for the removal of the travis test, for example). Please tell me which parts should be in a separate request, if any. With these changes, the Debian package passes the tests in the build tree, but also test/run-tests.sh --prog=whitakers-words --datadir=/usr/share/whitakers-words after installation. The third patch fixes an error detected by the command above. Thanks.

[mk270]

Thanks once again!

I've merged the first three of these (and yes, ideally submit changes lacking logical interdependencies as separate pull requests - this makes it easier to interleave merges with other branches, which is ongoing problem)

I'll have a look at the test script improvements shortly

[asarhaddon]

Hi. Despite its name, this merge request now only affects the test script. It would be convenient for the Debian packagers to know which part of this request you find interesting, even if it is not actually merged yet. (in case you are curious: git can rename files but the package internals use plain patches).

[mk270]

I don't think the software is DFSG-free; I think Debian has rejected it on that basis in the past, TICBW.

[mk270]

(this is of course no reason NOT to do good software engineering!)

[asarhaddon]

As far as I remember, LICENSE.txt was problematic because of the you can sell it as your own, but at least tell me restriction, which is stricto sensu not compatible with the DFSG.

This restriction arguably made sense while the author was alive, but quotes on the Notre Dame website show that his intent was not to forbid commercial use in the future.

Debian has found this convincing and has been distributing a whitakers-words package for more than two years.

Of course, now that you are the only maintainer and the Notre Dame website does not distribute this software or related quotes anymore, it would be nice to make your LICENSE.txt more explicit.

@calumapplepie will probably have more accurate memories.

(I do not understand TICBW)

[calumapplepie]

118 documents the problem; @asarhaddon 's memories are accurate, though. #118 has the continuation of this discussion; the Debian package's distribution is based on a license formed from the contents of the now-defunt website, as the current LICENSE.TXT is, in fact, non-free.

[asarhaddon]

Debugging the test script was a nightmare and led to several intermediate objectives.

• interrupt for any error, reporting the file name and line number
• remove trailing whitespaces
• remove DOS line terminator
• let all tests pass, including the new test by @calumapplepie (with a new ordering issue that I have not fully understood, but that is another story)

[asarhaddon]

This merge request is now focused on the test script.

[asarhaddon]

This rebase adapts the english test, which has been merged meanwhile.