Closed GoogleCodeExporter closed 9 years ago
Original comment by steven.b...@gmail.com
on 24 Jul 2012 at 5:53
Original comment by phi...@ogren.info
on 4 Aug 2012 at 5:36
The solution we've decided on is to deprecate all of the proliferators and copy
them to a new 'function' package. The copied versions will implement
com.google.common.base.Function<Feature, List<Feature>>. They will also be
named *FeatureFunction - so e.g. CapitalTypeFeatureProliferator will be called
CapitalTypeFeatureFunction. ProliferatingExtractor will be copied and called
FeatureFunctionExtractor
Original comment by phi...@ogren.info
on 4 Aug 2012 at 6:04
I have committed the new feature.function package. Here are a few
implementation details.
- added FeatureFunction interface to make it possible to have a varargs
constructor in FeatureFunctionExtractor
- changed static fields to enums, feature values are the strings from the enum
toString() methods
- the FeatureProliferator had a proliferate method that took a list of
features. I have duplicated this functionality in the one place this method
was used, in FeatureFunctionExtractor, as a static method.
This issue can be closed when the related compiler warnings are taken care of.
Original comment by phi...@ogren.info
on 5 Aug 2012 at 3:26
I've removed the compiler warnings
Original comment by phi...@ogren.info
on 5 Aug 2012 at 3:42
Original issue reported on code.google.com by
steven.b...@gmail.com
on 29 Apr 2011 at 10:07