search

mkabbasi / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

CoveredTextExtractor is poorly documented #387

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The CoveredTextExtractor surprisingly doesn't use annotation.getCoveredText() 
and instead allows for the possibility of using the text from a different view 
from the one that the annotation is in.  I can't think of why anyone would want 
this and so when I look at the code my brain trips over it.  However, we 
clearly did this deliberately because it says in the code that it's deliberate 
and there is a unit test that tests it.  If anyone can remember why we did it 
this way, then please document that class so that our current/future selves can 
understand why.  If not, then one way to analyze this is to change the code to 
the more obvious implementation and see if anything breaks.

Original issue reported on code.google.com by phi...@ogren.info on 25 Oct 2013 at 11:27

GoogleCodeExporter commented 8 years ago

Original comment by steven.b...@gmail.com on 26 Oct 2013 at 12:16

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision 88a9520aba6c.

Original comment by steven.b...@gmail.com on 26 Oct 2013 at 12:25