search

mkabbasi / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

XmiWriter in examples should be moved to cleartk-util #391

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I'd like to be able to use XmiWriter but I do not want to depend on 
cleartk-examples because I don't want to drag in everything that that module 
depends on just to use a utility class.  It seems to have a natural home in 
cleartk-util where there are other AEs and collection readers.  Now that 
XWriter has been removed from uimaFIT, it would be nice if we could provide it 
in a more convenient way.

Original issue reported on code.google.com by philip.o...@oracle.com on 30 Oct 2013 at 5:04

GoogleCodeExporter commented 8 years ago 
Sure. Mark it at @Beta though - I only created this a couple days ago, and only 
because of the upgrade to uimaFIT 2.0.0, so it hasn't been thoroughly tested. 
For that matter, if you move it into cleartk-util, you should write a test for 
it.

Original comment by steven.b...@gmail.com on 30 Oct 2013 at 5:09

GoogleCodeExporter commented 8 years ago 
I will add that the XmiWriter does not work with LineReader.  It would be nice 
if it did!

Original comment by philip.o...@oracle.com on 30 Oct 2013 at 5:35

GoogleCodeExporter commented 8 years ago 
When you say "does not work", what do you mean? Presumably there's a problem 
with the URI set by LineReader or something?

Original comment by steven.b...@gmail.com on 30 Oct 2013 at 5:40

GoogleCodeExporter commented 8 years ago 
Right.  The URI created by LineReader makes the line new 
File(ViewUriUtil.getURI(jCas)) throw an exception.  This deserves a separate 
issue.  I hadn't actually diagnosed it when I made the previous comment - just 
observed that it blew up.

Original comment by philip.o...@oracle.com on 30 Oct 2013 at 5:48

GoogleCodeExporter commented 8 years ago 
So, we have a bit of XmiWriter functionality in a few places:

org.cleartk.examples.XmiWriter
org.cleartk.summarization.SumBasic.XMIWriter
org.cleartk.timeml.eval.TempEval2010Evaluation.XMIWriter

Where the latter two seem to have cut-n-paste the same code.  I think I will 
copy one of these into cleartk-util, mark it @Beta, and call it done

Original comment by phi...@ogren.info on 15 Mar 2014 at 5:56

GoogleCodeExporter commented 8 years ago

Original comment by phi...@ogren.info on 15 Mar 2014 at 5:56

GoogleCodeExporter commented 8 years ago 
This should be a quick one....

Original comment by phi...@ogren.info on 30 Mar 2014 at 4:31

GoogleCodeExporter commented 8 years ago 
fixed in a43fc427882f161fac256dfe6b82afbe850ebfb7

added new org.cleartk.util.ae.XmiWriter to cleartk-util and removed redundant 
copies from TreebankParsingExample and SumBasic.

Original comment by phi...@ogren.info on 30 Mar 2014 at 5:10