search

mkaiser / Sungrow-SHx-Inverter-Modbus-Home-Assistant

Sungrow SH Integration for Home Assistant for SH3K6, SH4K6, SH5K-20, SH5K-V13, SH3K6-30, SH4K6-30, SH5K-30, SH3.RS, SH3.6RS, SH4.0RS, SH5.0RS, SH6.0RS, SH5.0RT, SH6.0RT, SH8.0RT, SH10RT, SH5.0RT-20, SH6.0RT-20, SH8.0RT-20, SH10RT-20, SH5.0RT-V112, SH6.0RT-V112, SH8.0RT-V112, SH10RT-V112, SH5.0RT-V122, SH6.0RT-V122, SH8.0RT-V122, SH10RT-V122, SH4.6R
344 stars 92 forks source link

Fix battery_charge_nominal and sensor.battery_charge #201

Closed mastameista closed 11 months ago

mastameista commented 11 months ago

Reported by: https://github.com/mkaiser/Sungrow-SHx-Inverter-Modbus-Home-Assistant/issues/200

According to https://developers.home-assistant.io/docs/core/entity/sensor/

device_class: battery has only % as supported unit of measurement. Here we need device_class: energy Or maybe even device_class: energy_storage ???

mastameista commented 11 months ago

My first PR :) hope I've done everything correctly.

mkaiser commented 11 months ago

I only modified the last update date

thank you very much! :)

mastameista commented 11 months ago

Perfect. Had no clue how to delete / undo my first commit :)

mkaiser commented 11 months ago

The "squash merge" on my side did the trick

mastameista commented 11 months ago

I see I have to learn a lot :) -> stopped developing when SVN was latest shit :D