Closed ABredhauer closed 8 months ago
I don't know if this would be needed. The problem is the different registers for anything else.
Yes I am finding that there are some registers not supported by these inverters currently but I'm not sure if this is a firmware issue or not as they are still very new. I thought I would start at least with the model code as the majority of sensors are still functional for me currently - testing on my SH10RS
A problem would be the missing sensors for the new registers. That‘s nothing you can fix with a firmware update. We could do a second version, but I think @mkaiser is already working on something new.
No I'm saying that the new registers listed in the doc are still reporting illegal addresses when I try to poll them - thats what I'm saying requires a firmware update. No point connecting a sensor to something that the inverter says doesn't exist.
I agree that this change doesn't enable full support for the new inverters but its a start. Happy to help you or @mkaiser work on a new file to support these ones, I've only been looking at this integration for a couple of weeks but feel like the architecture is going to need to change somehow to support the different product streams as they seem to be diverging and different models require different registers and sensors
hey,
it will take a while until I realized my thoughts on some yaml generation process. But small things like this help on the way! :)
thanks!
in case you are wondering... I just ammended your commit message from
"Adding Support for SH8.0RS and SH10RS Inverters #205" to "Adding device id for SH8.0RS and SH10RS Inverters #205"
thanks I'll try and make future commits more specific
Adding support for these device codes