mkaiser / Sungrow-SHx-Inverter-Modbus-Home-Assistant

Sungrow SH Integration for Home Assistant for SH3K6, SH4K6, SH5K-20, SH5K-V13, SH3K6-30, SH4K6-30, SH5K-30, SH3.RS, SH3.6RS, SH4.0RS, SH5.0RS, SH6.0RS, SH5.0RT, SH6.0RT, SH8.0RT, SH10RT, SH5.0RT-20, SH6.0RT-20, SH8.0RT-20, SH10RT-20, SH5.0RT-V112, SH6.0RT-V112, SH8.0RT-V112, SH10RT-V112, SH5.0RT-V122, SH6.0RT-V122, SH8.0RT-V122, SH10RT-V122, SH4.6R
326 stars 83 forks source link

Simplify setup by removing secrets #7

Closed johschmitz closed 2 years ago

johschmitz commented 2 years ago

I replaced all the secrets in the yaml file in order to make the setup easier. After all they are no secrets just an IP and a port number. I suggest you also do that and simplify the documentation accordingly.

johschmitz commented 2 years ago

See this pull request: https://github.com/mkaiser/Sungrow-SHx-Inverter-Modbus-Home-Assistant/pull/8

Now everything is working for me 😀

mkaiser commented 2 years ago

continuing discussion in PR