Extend for multi tenant project

mkalioby / django-passkeys

Django Authentication Backend For Passkeys

MIT License

197 stars 21 forks source link

Extend for multi tenant project #1

Closed jacopsd closed 1 year ago

jacopsd commented 1 year ago

To use Django-passkeys in a multi tenant project, the FIDO_SERVER_ID and FIDO_SERVER_NAME cannot be hard coded in the settings, but must be retrieved via a callable.

Changes:

Callable FIDO_SERVER_ID and FIDO_SERVER_NAME
For calls to getServer(): pass Django request as argument, to be able to extract server ID from request
"black" code cleaning: 2 empty lines before function definition

mkalioby commented 1 year ago

Thanks for your contribution.

I'll give it a try and will let you know.

mkalioby commented 1 year ago

Hello @jacopsd,

Sorry for the late reply, please update the README accordingly.

Thanks and welcome to the contributors

jacopsd commented 1 year ago

Dear Mohamed

I saw you already updated the README. Thank you.

Best Regards Davy Jacops

On 21 May 2023 at 15:09 +0200, Mohamed El-Kalioby @.***>, wrote:

Hello @jacopsd, Sorry for the late reply, please update the README accordingly. Thanks and welcome to the contributors — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>