search

mkaply / cck2wizard

CCK2
Mozilla Public License 2.0
46 stars 9 forks source link

win is null in CAPSClipboardFramescript #103

Closed cjcenizal closed 5 years ago

cjcenizal commented 5 years ago

Hi there, I'm a maintainer of Kibana and we've had reports from some of our users who also use CCK2 of crashes due to win being null at https://github.com/mkaply/cck2wizard/blob/master/cck2/modules/CAPSClipboardFramescript.js#L72. I'm not familiar with CCK2's source code so I'm not sure how this could evaluate to null or how Kibana could be causing this, but I thought I would suggest a null check here and on similar lines to protect CCK's users from this problem. Thanks!

mkaply commented 5 years ago

That's really odd. That genuinely should never happen, but I'll add a null check.