Try to really guess the userAgentLocale when general.useragent.locale…

[shadeslayer]

… fails

Fixes #69

[mkaply]

Was this on 58 or 59?

[mkaply]

So I think the right API here is actually Services.locale.getRequestedLocale()

This pref was removed in 59.

[shadeslayer]

This was on Firefox 58

[shadeslayer]

Using Services.locale.getRequestedLocale caused a segfault on Firefox 58 for me.

It also seems this entire code path is really slow on ARM since the rest of the UI get's setup and the bookmarks appear after 10-15 seconds.

[mkaply]

OK, I'm really confused. Firefox 58 still had the general.useragent.locale preference.

Are you on Linux?

[shadeslayer]

I am indeed on Linux. While FF 58 still has general.useragent.locale, the value that I get from Preferences.defaults.get is undefined. In about:config, the same value is set to en when in reality the locale should have been de.

[shadeslayer]

Bump?

[mkaply]

Sorry. I still don't understand your last few comments.

Can you tell me the value of intl.locale.matchOS on your Firefox 58?

[shadeslayer]

It's set to false for some reason :S

[mkaply]

Most Linux versions set it to true. Strange. I think I know of a better way to do this because I actually need to get the chrome locale. I'll try another patch.

[shadeslayer]

Yeah, it's quite odd

[mkaply]

I ended up with a different patch for this for Firefox 60. Please take a look. Thanks!