search

mkarhumaa / gifmaker

Software for converting video segments to animated GIF.
2 stars 0 forks source link

Testing #16

Closed ropelli closed 10 years ago

olihub commented 10 years ago

Added few folders to demonstrate gifs at different FPS and scaling from 100% to 50%.

olihub commented 10 years ago

https://www.dropbox.com/sh/noqrxqt2gxm3xf4/aVe2we7Hd9

olihub commented 10 years ago

Do we have the newest version of converter in here? We still had some character encoding issues.

mkarhumaa commented 10 years ago

Sorry, no we dont. Did not remember to do new build yesterday. And now I do not have my laptop with me. 27.11.2013 9.41 "olihub" notifications@github.com kirjoitti:

Do we have the newest version of converter in here? We still had some character encoding issues.

— Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29365401 .

olihub commented 10 years ago

Ok, thanks! Was just wondering if it still were broken. We'll just finish the python code and ignore the issue.

mkarhumaa commented 10 years ago

Great! I will make a new build later today when getting back to home. 27.11.2013 9.45 "olihub" notifications@github.com kirjoitti:

Ok, thanks! Was just wondering if it still were broken. We'll just finish the python code and ignore the issue.

— Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29365511 .

olihub commented 10 years ago

New demo at ~ookkonen. Gifs taken at 1fps and showed 2x speed. File size average around 700-800k.

Ready for monday's presentation?

HenriH89 commented 10 years ago

Should the frame rate be a little bit higher? Those gifs are just not very pleasant to watch now. What do you think?

olihub commented 10 years ago

It's not supposed to be a video as gif but a collection of images. I tried 1 fps at normal speed but that seemed kinda slow. You can try different frame rates if you want (posted a link of 1-10 fps to dropbox in another issue).

I'm doing a HQ edition for presentation too. 100% size at 8 fps.

But you can imagine 20-30 MB gifs * 7 for a page..

But if you do find great size/fps/speed ratios, please do post here and ill update the page.

Oh, and can someone confirm that page works with IE too? My IE is in a crash loop :)

ropelli commented 10 years ago

Works in IE when fully downloaded the site. But the pictures and gifs seem to download slower or at least you can see them loading i.e. black boxes.

HenriH89 commented 10 years ago

Hmm. I understood the topic so that it was supposed to be a video as a gif. So you could watch those video clips without the need of external player. I understand it is very heavy and compromises have to be made. That was one thing we needed to focus on.

Well, an HQ edition for the presentation is great :)

mkarhumaa commented 10 years ago

I prefer the high framerate animation for demo purpose. Looks better!:)

However, user is able to configure the converter so that output animation fits to their needs.

Seems to be working on older smartphone too. 30.11.2013 12.24 "HenriH89" notifications@github.com kirjoitti:

Hmm. I understood the topic so that it was supposed to be a video as a gif. So you could watch those video clips without the need of external player. I understand it is very heavy and compromises have to be made. That was one thing we needed to focus on.

Well, an HQ edition for the presentation is great :)

— Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29549825 .

olihub commented 10 years ago

Uploaded HQ version to site too. Is 8 fps enough or do you want the 10 fps version?

olihub commented 10 years ago

The Wire - LQ: 11MB The Wire - HQ 60MB :dancers:

HenriH89 commented 10 years ago

Looks good to me. HQ versions definately give better image of what's happening in the scene. Heavy as hell but good for demonstrating :D

olihub commented 10 years ago

We can start with LQ and leave HQ for final wow element.

Sent from Samsung Mobile

-------- Original message -------- From: HenriH89 notifications@github.com Date: To: mkarhumaa/gifmaker gifmaker@noreply.github.com Cc: Olli Okkonen Olli.Okkonen@student.oulu.fi Subject: Re: [gifmaker] Testing (#16)

Looks good to me. HQ versions definately give better image of what's happening in the scene. Heavy as hell but good for demonstrating :D

Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29550506.

ropelli commented 10 years ago

Web application also works through our project website @ http://www.ee.oulu.fi/~rokallio/MMS13/index.html . Just click Application.

ropelli commented 10 years ago

No-one in their right mind should even make longer GIFs than one or two subtitle segment if they want to use it as a preview. No-one will hover on an image for more than like 5 seconds.

olihub commented 10 years ago

Spend those 5 seconds wisely :)

Error found too:

C:\java_conv\test>java -jar converter.jar THE_WIRE_HQ.mp4 THE_WIRE.srt 3-4 1-2 Parsing SRT file: THE_WIRE.srt Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader.main(JarRsrcLoa der.java:58) Caused by: java.lang.IndexOutOfBoundsException: Index: 2, Size: 2 at java.util.ArrayList.rangeCheck(Unknown Source) at java.util.ArrayList.get(Unknown Source) at com.gifmakers.Converter.parseSRT(Converter.java:446) at com.gifmakers.Converter.main(Converter.java:156) ... 5 more

HenriH89 commented 10 years ago

You probably don't have the newest version of the converter.

Matias, have you uploaded it?

olihub commented 10 years ago

Ill download newest version and try if i can replicate the error later tonight. It's not urgent issue anyways.

Sent from Samsung Mobile

-------- Original message -------- From: HenriH89 notifications@github.com Date: To: mkarhumaa/gifmaker gifmaker@noreply.github.com Cc: Olli Okkonen Olli.Okkonen@student.oulu.fi Subject: Re: [gifmaker] Testing (#16)

You probably don't have the newest version of the converter.

Matias, have you uploaded it?

Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29569073.

mkarhumaa commented 10 years ago

I made a new build few seconds ago. I think it was outdated...

2013/12/1 olihub notifications@github.com

Ill download newest version and try if i can replicate the error later tonight. It's not urgent issue anyways.

Sent from Samsung Mobile

-------- Original message -------- From: HenriH89 notifications@github.com Date: To: mkarhumaa/gifmaker gifmaker@noreply.github.com Cc: Olli Okkonen Olli.Okkonen@student.oulu.fi Subject: Re: [gifmaker] Testing (#16)

You probably don't have the newest version of the converter.

Matias, have you uploaded it?

Reply to this email directly or view it on GitHub< https://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29569073>.

— Reply to this email directly or view it on GitHubhttps://github.com/mkarhumaa/gifmaker/issues/16#issuecomment-29569136 .

olihub commented 10 years ago

Ran previous script with newest build - Handled perfectly!

Managed to get another error though:

file a.srt: "1 00:00:36,677 --> 00:00:41,285 Saksan metsistä kerrotaan lukuisia tarinoita ja myyttejä. "

C:\java_conv\test>java -jar converter_new.jar THE_WIRE_HQ.mp4 a.srt 1-2 Parsing SRT file: a.srt Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader.main(JarRsrcLoa der.java:58) Caused by: java.lang.NullPointerException at com.gifmakers.Converter.combineFrames(Converter.java:401) at com.gifmakers.Converter.parseSRT(Converter.java:356) at com.gifmakers.Converter.main(Converter.java:156) ... 5 more:

(1 found in .SRT and 2 not found in .SRT)

Otherwise program seems to operate very robustly.

HenriH89 commented 10 years ago

Fixed the (hopefully) final bug. Matias can upload the new build.

mkarhumaa commented 10 years ago

Uploaded latest build to the dropbox.

mkarhumaa commented 10 years ago

Tested to run CreateHTML.py script and noticed that it requires css file to work. Please upload the css file to github. Also proper error handling would be nice.

matias@matias-laptop:~/MMS$ python CreateHTML.py [] Traceback (most recent call last): File "CreateHTML.py", line 174, in with open("style_template.css", mode='r') as f: IOError: [Errno 2] No such file or directory: 'style_template.css' matias@matias-laptop:~/MMS$

olihub commented 10 years ago

Added style.css.

Ill clean up the .css and fix createhtml.py before meeting on Wednesday.

mkarhumaa commented 10 years ago

I think it requires style_template.css??

olihub commented 10 years ago

Good point! Added both templates.

ropelli commented 10 years ago

testing done