search

mkaring / ConfuserEx

An open-source, free protector for .NET applications
https://mkaring.github.io/ConfuserEx/
MIT License
2.38k stars 370 forks source link

Fix Newtonsoft Serialization #444

Closed ghost closed 2 years ago

ghost commented 2 years ago

Do not Rename Arguments, Fixes the error " A member with the name ' ' already exists"

AppVeyorBot commented 2 years ago

:white_check_mark: Build ConfuserEx 913 completed (commit https://github.com/mkaring/ConfuserEx/commit/3cf244d57c by @Yeetret)

AppVeyorBot commented 2 years ago

:white_check_mark: Build ConfuserEx 914 completed (commit https://github.com/mkaring/ConfuserEx/commit/93ad3840ec by @Yeetret)

ElektroKill commented 2 years ago

Hi, This "fix" will severely decrease the effectiveness of rename protection even on members which aren't involved in JSON serialization or deserialization when Newtonsoft.JSON reference is detected. I don't believe this is a proper way to resolve this problem.

wmjordan commented 2 years ago

If this is a fix, why not just remove the "rename" protection?

mkaring commented 2 years ago

Sorry, this change is not going to be included. This disables the obfuscation parameters that are completely unrelated to the json serialization.