mkarneim / pojobuilder

A Java Code Generator for Pojo Builders
Other
334 stars 44 forks source link

Stop catching Error in build method #84

Closed drekbour closed 10 years ago

drekbour commented 10 years ago

catch (Throwable t) gets picked up by every code analysis tool as a "bad thing" (VM level) Errors should not be caught except by code designed specifically to handle them.

Supplied code is more idiomatic Java for doing this (without Guava's Throwables class!)

mkarneim commented 10 years ago

Ah, good point. Thanks!