mkasberg / script-seed

🌱 Seed scripts for popular (& unpopular) scripting languages.
https://mkasberg.github.io/script-seed/
MIT License
11 stars 23 forks source link

Update Dockerfile to Ubuntu 20.04 #29

Closed termdew closed 4 years ago

termdew commented 4 years ago

Update Dockerfile:

Note: Powershell is not available for Ubuntu 20.04 as a package, therefore prebuilt binaries are needed.

mkasberg commented 4 years ago

Oh, this is great! Love that you made the container work for serving the site locally too. I do think we should update the readme to reflect that as an option.

I think you broke the tests by changing the ENTRYPOINT in the Dockerfile. https://travis-ci.org/github/mkasberg/script-seed/builds/719719043

The tests use docker to run test.sh (see .travis.yml) - I suspect it's now simply serving the site with your entrypoint rather than running the tests and exiting. Maybe if you use CMD instead of ENTRYPOINT it will work?

termdew commented 4 years ago

I fixed it now. Now the tests run as entrypoint. After the tests, the Python2 server kicks in.

mkasberg commented 4 years ago

Looks great! Thanks!