mkasberg / script-seed

🌱 Seed scripts for popular (& unpopular) scripting languages.
https://mkasberg.github.io/script-seed/
MIT License
11 stars 23 forks source link

deno seed created #65

Closed vigneshrajj closed 3 years ago

vigneshrajj commented 3 years ago

PR looks good overall!

I think running chmod +x deno_seed.js will make the file executable so the tests can pass.

I have already done that and the tests are passing locally. This is only happening on pull request.

mkasberg commented 3 years ago

I checked out your branch and confirmed that it's still missing the executable file mode (as of a few minutes ago):

$ ls -l seeds/
-rwxr-xr-x 1 mkasberg mkasberg  362 Oct 19  2018 awk_seed.awk
-rwxrwxr-x 1 mkasberg mkasberg  633 Oct 18  2020 bash_seed.sh
-rw-rw-r-- 1 mkasberg mkasberg  522 Oct 10 07:53 deno_seed.js
-rwxrwxr-x 1 mkasberg mkasberg 1704 Oct  6  2020 erlang_seed.erl
-rwxrwxr-x 1 mkasberg mkasberg  438 Oct 12  2020 go_seed.go
-rwxrwxr-x 1 mkasberg mkasberg  487 Oct 18  2020 groovy_seed.groovy
-rwxrwxr-x 1 mkasberg mkasberg  809 Oct  9 08:52 javascript_seed.js
-rwxrwxr-x 1 mkasberg mkasberg  660 Oct 14  2020 julia_seed.jl
-rwxrwxr-x 1 mkasberg mkasberg  636 Oct 10  2020 lua_seed.lua
-rwxr-xr-x 1 mkasberg mkasberg  847 Oct 21  2018 perl_seed.pl
-rwxrwxr-x 1 mkasberg mkasberg  726 Oct 18  2020 php_seed.php
-rwxr-xr-x 1 mkasberg mkasberg  496 Oct 12  2020 powershell_seed.ps1
-rwxrwxr-x 1 mkasberg mkasberg  504 Oct 14  2020 python_seed.py
-rwxr-xr-x 1 mkasberg mkasberg  452 Oct  1  2019 ruby_seed.rb
-rwxr-xr-x 1 mkasberg mkasberg  486 Oct 19  2018 scala_seed.scala
-rwxrwxr-x 1 mkasberg mkasberg  453 Oct 14  2020 tcl_seed.tcl

It seems like you have it correct (executable) locally but not in the Git commit. Try this:

$ git update-index --chmod=+x path/to/file

https://stackoverflow.com/questions/40978921/how-to-add-chmod-permissions-to-file-in-git

mkasberg commented 3 years ago

Looks great! Thanks!

vigneshrajj commented 3 years ago

Thank you