search

mkaz / termgraph

a python command-line tool which draws basic graphs in the terminal
MIT License
3.15k stars 164 forks source link

Configure setup.py to only install in python >=3.6 #38

Closed jagmoreira closed 6 years ago

jagmoreira commented 6 years ago

Currently termgraph can only run under python 3.6 (see #28).

To avoid surprising users at runtime with a SyntaxError message, I think it makes sense to prevent installation altogether in python < 3.6. These changes enforce a python >=3.6 at the setup.py level.

@mkaz Let me know if you're interested in making the package backwards compatible. I'd be happy to help!

mkaz commented 6 years ago

I don't have a good sense of what the larger Python community uses and what is the common default install across platforms. So I'm not sure if any effort is worth support for earlier 3.x versions.

Python 3.6 was released in December 2016, and is the default Python version in Ubuntu 18.04, so my guess is most are using it.

So it seems like supporting 3.6 and up should be fine, we can merge this and fix later if some one complains about earlier version support.

jagmoreira commented 6 years ago

This blog post has some numbers regarding adoption of earlier 3.x versions, but they are not very reliable by the authors own admission.

According to this survey, 25% of developers are still using python 2. Yikes! I would not recommend supporting python 2...

For what is worth, I use 3.6 for mostly everything.