mkazhdan / PoissonRecon

Poisson Surface Reconstruction
MIT License
1.56k stars 425 forks source link

A question about compile v2/v3/v4 source code #301

Open RainSureZhao opened 2 months ago

RainSureZhao commented 2 months ago

Hello, when I try to compile the source code for version v2/v3/v4 using the Makefile, I use make all/make release, but I am told that AddTriangles() is not found.

The error message is here:

In file included from Src/MultiGridOctreeData.h:254,
                 from Src/MultiGridOctest.cpp:86:
Src/MultiGridOctreeData.inl: In static member function 'static int Octree<Degree>::AddTriangles(CoredMeshData*, std::vector<CoredPointIndex>*, std::vector<Point3D<float> >*, const int&)':
Src/MultiGridOctreeData.inl:2279:53: error: no matching function for call to 'Octree<Degree>::AddTriangles(CoredMeshData*&, std::vector<CoredPointIndex>&, std::vector<Point3D<float> >*&, const int&)'
  return AddTriangles(mesh,e,interiorPositions,offSet);

Compilation environment: ubuntu 22.04 GNU Make 4.3 g++ 11.4.0

mkazhdan commented 2 months ago

It's been a while since I've looked at those versions. Just out of curiosity, is there a reason you're not using a newer version?

RainSureZhao commented 2 months ago

It's been a while since I've looked at those versions. Just out of curiosity, is there a reason you're not using a newer version?

Because I am reading the original paper in 2006, I want to cooperate with the code reading so that the understanding will be deeper. Now I have learned the code of V1 version, and I want to know what upgrades and changes have been made in V2, V3, V4 and other versions, so I tried to compile it, but something went wrong, and the code of V1 version will not report errors. So I want to know why.

mkazhdan commented 2 months ago

I have updated the source code in Version2/3/4. It should now compile using the Makefile. (I also added a Makefile to Version4.)

Note that as I was developing on a machine without OpenMP, I disabled the parallelization calls in Version4.

RainSureZhao commented 1 month ago

I have updated the source code in Version2/3/4. It should now compile using the Makefile. (I also added a Makefile to Version4.)

Note that as I was developing on a machine without OpenMP, I disabled the parallelization calls in Version4.

Thank you very much!