search

mkclawson / impala

Apache License 2.0
2 stars 3 forks source link

feature: Social sharing on bottom #10

Open helms-charity opened 1 year ago

helms-charity commented 1 year ago

Currently there are 2 places to share, top and bottom of blog posts. This ticket is for the bottom part.

At the bottom left of the post content, the icons are visible and clicking brings up only the popup for the service. image

TODO: Decide if we want both styles/locations?

jzachari commented 1 year ago

Mike is leaving it up to us on which way to share to social media. I personally think the three dots is not intuitive. As for which free third party to use. It is up to us.

meejain commented 1 year ago

@jzachari @helms-charity - for https://github.com/mkclawson/impala/issues/10 - if we use any 3rd party service wont that impact the LHS of that page . May be .. may b not. For what as per my experience - these 3rd party apps do ask for a certain DIV with a certain ID. It searches that page with that ID and put that pop up on that DIV automatically with all JS / CSSin place. I can take a peek at them once my autoblocking Blog pages is done. Hopefully soon . I am still a bit engaged with Orora.

helms-charity commented 1 year ago

Your concern is a valid one, but I believe we can look at using delayed.js and some styling of the containers where the content will be populated so there is not a shift.

helms-charity commented 1 year ago

I'm taking this ticket because I think I found another Franklin project that wrote their own Sharing script, I'm looking at it now.