mkclawson / impala

Apache License 2.0
2 stars 3 forks source link

Issue19 configuring blog intro #20

Closed meejain closed 1 year ago

meejain commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #19

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
helms-charity commented 1 year ago

There is too much spacing above the post title. Top image is the live site at https://www.supernaturalimpala.com/post/blogging-from-your-live-site-mobile . image

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/Drafts/Meet/blog/rocky-mountain-snow PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
meejain commented 1 year ago

@helms-charity - Pl check now if the pages are working fine after coding a new Block - https://github.com/mkclawson/impala/tree/issue19-configuring-blog-intro/blocks/blogintro

https://issue19-configuring-blog-intro--impala--mkclawson.hlx.live/Drafts/Meet/blog/rocky-mountain-snow https://issue19-configuring-blog-intro--impala--mkclawson.hlx.live/Drafts/Meet/blog/pandemic-woes https://issue19-configuring-blog-intro--impala--mkclawson.hlx.live/Drafts/Meet/blog/garaged https://issue19-configuring-blog-intro--impala--mkclawson.hlx.live/Drafts/Meet/blog/bringin-back-baby

helms-charity commented 1 year ago

There should also be dots separating the author, date, and read time.

helms-charity commented 1 year ago

your JS should get the info from the metadata and automatically prepend that data above the H1. See this autoblocked code in scripts.js as an example. https://github.com/hlxsites/merative2/blob/main/scripts/scripts.js#L133

Example of on-page use: https://main--merative2--hlxsites.hlx.page/blog/cardiovascular-image-and-management-evolution image