hw2 review - Githubissues

mkcomer237 / DAT_SF_16

0 stars 0 forks source link

hw2 review #4

Open janeyho opened 9 years ago

janeyho commented 9 years ago

Hi Matt,

In item 4 of your python notebook, I'm not sure I understand why you need the cleanline for loop.

for line in rawfile:

cleanline = line.strip()
if cleanline == '':
    continue 

tweetfull = json.loads(line.strip())

@ghego @Breucopter

mkcomer237 commented 9 years ago

Yeah it looks like that is redundant - i was originally having trouble because the tweets were spaced out a few lines in the results but I ended up not needing that code. Also it's Max, not Matt :)

janeyho commented 9 years ago

OPPS . sorry, MAX!

ghego commented 9 years ago

Congrats on doing HW2!

a couple of comments:

could you have downloaded the data in the pandas dataframe without the command line pipe? (very nice tool btw)
do you know the with(... ) python command? If not maybe worth checking out.
the graph is nice. the Y axis is labeled as "count", are you sure it's a count?