mkdocs / mkdocs-bootswatch

MkDocs Bootswatch Themes
http://mkdocs.github.io/mkdocs-bootswatch
BSD 2-Clause "Simplified" License
144 stars 60 forks source link

Update themes to the latest from mkdocs core #36

Closed jimporter closed 6 years ago

jimporter commented 6 years ago

@waylan This adds the following changes from mkdocs core to the bootswatch themes. I just copied the files over to src/_base and then added the CSS changes from the keyboard nav commit. I did a quick local test and everything appears to be working.

waylan commented 6 years ago

@jimporter thanks for keeping these up-to-date.

Btw, the 01.7 release of MkDocs includes support for themes to extend other themes. Rather than needing to "generate" the themes here, I wonder of inheritance should be used instead. In fact, I expect that these themes could all extend the mkdocs theme. That way, they would get any (non CSS) updates automatically. If, for some reason, they can't extend the mkdocs theme, they should be able to extend on of their own (set one as the base which is a complete theme and all other extend it only providing the files that differ). I accepted this PR anyway because it included CSS changes which still needed to be made, but using inheritance should cut down on the work to keep things up-to-date.

marcelstoer commented 6 years ago

Shouldn't this have bumped the version in setup.py? Also, in strict mode the theme config file in _base doesn't seem to be picked up: https://github.com/mkdocs/mkdocs-bootswatch/issues/38#issuecomment-359127584

waylan commented 6 years ago

@marcelstoer the version will be bumped when a new version is released. I don't have the ability to upload a new release (to PyPI) and those who do seem to not be interested in doing so. Until then, we won't get any new versions of these themes.

marcelstoer commented 6 years ago

Thanks for the feedback Waylan. Who are they? Can they be pinged and asked for help?

ghost commented 6 years ago

Can we somehow fix this problem with the themes? We have to stick to mkdocs 0.16.3 right now because of this problem. Is there a way to workarround this issue with the theme files to be able to use the latest mkdocs version?

waylan commented 6 years ago

@dschwabeS11 you can always install directly from the latest in git with:

 pip install -U git+https://github.com/mkdocs/mkdocs-bootswatch.git
ghost commented 6 years ago

Yes of course, but it would be better if it was fixed properly.

Wdavery commented 6 years ago

I get the following when running that command. Collecting git+https://github.com/mkdocs/mkdocs-bootswatch.git Cloning https://github.com/mkdocs/mkdocs-bootswatch.git to /tmp/pip-req-build-cKiyUm Collecting mkdocs>=1.0 (from mkdocs-bootswatch==1.0) Could not find a version that satisfies the requirement mkdocs>=1.0 (from mkdocs-bootswatch==1.0) (from versions: 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.11.1, 0.12.0, 0.12.1, 0.12.2, 0.13.0, 0.13.1, 0.13.2, 0.13.3, 0.14.0, 0.15.0, 0.15.1, 0.15.2, 0.15.3, 0.16.0, 0.16.1, 0.16.2, 0.16.3, 0.17.0, 0.17.1, 0.17.2, 0.17.3, 0.17.4, 0.17.5) No matching distribution found for mkdocs>=1.0 (from mkdocs-bootswatch==1.0)

I do have mkdocs install locally using --user, is that what is causing this error?

waylan commented 6 years ago

@Wdavery we have made multiple releases since the above comment was made. And, in fact, no changes have been made since the most recent release. Therefore you should be able to install an official release rather than directly from git.

That said, the error is because the most recent release of the theme requires MkDocs version 1.0 or later, but such a version was not found. I'm guessing you have an early version of Python version 2.7 (prior to 2.7.9) as MkDocs 1.0 requires Python 2.7.9 or later. If you don't specify any versions in your pip command, then the latest available for your system will be installed. If you really want/need the latest version, then you will need to update Python as well.

Wdavery commented 6 years ago

Thanks for the quick help! You are exactly right about the python version so that all makes sense.