search

mkdocs / mkdocs-redirects

Open source plugin for Mkdocs page redirects
MIT License
176 stars 25 forks source link

Assorted tweaks #22

Closed XhmikosR closed 2 years ago

XhmikosR commented 3 years ago

@burkestar the only things I don't like so far but I don't have the bandwidth to fix all of them:

  1. a requirements.txt would help with the dependencies + CI caching
  2. the makefile while it works, on CI it triggers a reinstall (the dev target)
  3. at some point the backslashes replacement should be refactored into a function
  4. at another point, I'd drop Python 2.x support and use Pathlib. Maybe there's another way, but I'm not super familiar with Python
  5. Python 3.4 isn't tested on CI because it throws errors, so I went with >= 3.5
  6. The HTML should still be valid
  7. The plan would be to eventually switch to the full site URLs, but that's for another time

EDIT: the CI will run after this is merged but you can see a preview: https://github.com/pi-hole/mkdocs-redirects-redux/actions/runs/1067811019