Closed llucax closed 1 year ago
Thanks for the report!
Yes, latest Griffe added support for Modules, Classes, Functions and Methods sections. The parser is a bit too lax, I'll add an option to make it more strict, and we'll add a deprecation period for the default behavior, to switch to strict by default at some point.
In the end I didn't add an option. I expect most users already use valid syntax for sections. The docs mention a way to find out possibly invalid syntax. Released in v0.35.2.
Hi @pawamoy , thanks for addressing this so quickly. So it's unclear for me if this is expected behaviour from now on or not. It is now invalid to have just the words modules:
in its own line?
Asking to know how should we format our doc comments. Thanks!
Oh, good question, I guess I could have given more explanations.
Your example docstring above is perfectly valid. Before, the parser would parse it as an empty modules section, which was wrong. Now, with our stricter parsing rules, it is correctly parsed as regular text.
I hope this answers your question.
Yes, crystal clear now! Thanks!
Describe the bug
This is a regression, it didn't happen with griffe 0.31.0. I'm not using griffe directly, but from mkdocstrings and the dependency was indirectly updated.
Debug logs No griffe logs.
To Reproduce Steps to reproduce the behavior:
I hope it is enough to show a public repo with this issue.
You can see a GitHub workflow failing here: https://github.com/frequenz-floss/frequenz-repo-config-python/actions/runs/5980689722/job/16227308937?pr=125
Expected behavior It should work as before. A paragraph split in more than one line shouldn't be considered a section.
System (please complete the following information):
griffe
version: 0.35.0Additional context None.