search

mkeeter / kokopelli

Script-based CAD/CAM in Python (deprecated)
https://mattkeeter.com/projects/kokopelli
Other
298 stars 49 forks source link

Fix load of binary stl files #17

Closed tytouf closed 9 years ago

tytouf commented 10 years ago

These changes are meant to fix the crash described in issue #16 "Crash when loading a .stl file". This commit also fixes the boundaries of the mesh.

mkeeter commented 10 years ago

Hi Christophe,

I'm giving you commit access to kokopelli (as inspired by this discussion).

Feel free to merge in your pull request and other fixes / improvements you feel like making.

This PR appears to fix the crash, and I confirm that .stls still aren't being displayed. To be honest, I'm not entirely sure why I put in the option to load .stls -- I don't think that the CAM workflow works on them, so (if displaying them worked) all it would do is act as a viewer.

Regards, Matt

tytouf commented 10 years ago

Hi Matt,

Thanks!

I agree that at the moment it would only serve as a viewer but it would be great to make it generate an image of the depth map that can later be used in the cam workflow.

Kind regards,

Hi Christophe,

I'm giving you commit access to kokopelli (as inspired by this discussion http://felixge.de/2013/03/11/the-pull-request-hack.html).

Feel free to merge in your pull request and other fixes / improvements you feel like making.

This PR appears to fix the crash, and I confirm that .stls still aren't being displayed. To be honest, I'm not entirely sure why I put in the option to load .stls -- I don't think that the CAM workflow works on them, so (if displaying them worked) all it would do is act as a viewer.

Regards, Matt

— Reply to this email directly or view it on GitHub https://github.com/mkeeter/kokopelli/pull/17#issuecomment-49230527.