search

mkeoliya / pe

0 stars 0 forks source link

Invalid dates permitted #8

Open mkeoliya opened 3 years ago

mkeoliya commented 3 years ago

Steps to Reproduce

  1. addBooking pid/5 rid/2120 sd/2019-02-12 ed/2019-02-29
  2. addBooking pid/5 rid/2120 sd/2019-04-29 ed/2019-04-31

Expected: Error showing invalid date, because 29th Feb in 2019, and 31st April in any year don't actually exist. Actual: The booking is added anyway.

nus-pe-bot commented 3 years ago

Team's Response

We are just using an existing, popular Java library LocalDate.parse() method. This LocalDate library is also recommended to all students to use in iP by Prof Damith. This way of error handling is decided by the Java libary developers and not up to us to decide. Therefore, this is not in the scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The lack of date validation does not satisfy either of the two conditions for an issue to be out of scope, since the UG doesn't acknowledge it nor does the system provide a suitable error message.
Screenshot 2020-11-18 at 8.33.08 PM.png

Further, the user (or tester) shouldn't be concerned with the implementation of a functionality or which class is being used, and the behaviour should either be as expected, or should be specified clearly in the UG. Regardless, do note that it is almost trivial to sanity check a date using the LocalDate Java libraries : here.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Rejecting an issue does not mandate decreasing its severity. The lack of an error message while accepting an invalid date is not purely cosmetic or a typo, and does not justify the VeryLow tag.