mkevenaar / chocolatey-packages

My chocolatey packages
https://mkevenaar.github.io/chocolatey-packages/
Apache License 2.0
42 stars 66 forks source link

(jetbrainstoolbox) advertise product to current user for background service installations #151

Closed shawnfunke closed 1 year ago

shawnfunke commented 1 year ago

Description

This change will adjust the installation of the JetBrains Toolbox to advertise the product to the current user.

Motivation and Context

This fixes an issue when using the Chocolatey background service for installing this software. The JetBrains Toolbox is a per-user installation, when using the Chocolatey background service the software is only installed for the ChocolateyLocalAdmin user, with the /ju MSI flag it will get advertised to the user invoking the installation and be available for them as well.

How Has this Been Tested?

This has been tested in our cooperate environment using Chocolatey for Business, using the background service. A sandbox VM was used to test the change without using the background service, the behaviour there is untouched.

This change has also been tested using the /jm flag, while the Microsoft documentation states that this will advertise the product machine wide, this didn't seem to work in practice in my tests.

Screenshot (if appropriate, usually isn't needed):

N/A

Types of changes

Checklist:

AppVeyorBot commented 1 year ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 1 year ago

@shawnfunke your changes have been merged and will be available on the next release of Jetbrains Toolbox

Thank you for your contribution!

shawnfunke commented 1 year ago

Great, thanks!