mkevenaar / chocolatey-packages

My chocolatey packages
https://mkevenaar.github.io/chocolatey-packages/
Apache License 2.0
42 stars 66 forks source link

Replace blurry https://github.com/mkevenaar/chocolatey-packages/blob/master/icons/crystaldiskinfo.png with non-blurry image #162

Closed jpluimers closed 1 year ago

jpluimers commented 1 year ago

https://github.com/mkevenaar/chocolatey-packages/blob/master/icons/crystaldiskinfo.png is a blurry 200x202x8:

crystaldiskinfo.png 200x202x8

There is a much better 256x256x32 image available from the .ICO file that is in the CrystalDiskInfo repository, see https://github.com/mkevenaar/chocolatey-packages/issues/159#issuecomment-1366174481 :

... 256x256x32 language neutral icons I extracted using Resource Editor (one of the few free ones that support modern icon/bitmap formats used in Windows Vista and up but regrettably there is no Chocolatey package for it yet) from https://github.com/hiyohiyo/CrystalDiskInfo/blob/master/resN/DiskInfo.ico and https://github.com/hiyohiyo/CrystalDiskMark/blob/master/res/DiskMark.ico to BMP files, then converted to PNG using mspaint.exe (which has come a long way ver the last few Windows versions in becoming actually useful).

The first file is better than your current 200x200x8 icon as it does not suffer from image compression and sizing artefacts.

CrystalDiskInfo-256x256x32-language-neutral.png CrystalDiskInfo-256x256x32-language-neutral.png

TODO after fixing this

  1. find all places where the original 200x200@8-bit image is used from other references than https://raw.githubusercontent.com/mkevenaar/chocolatey-packages/master/icons/crystaldiskinfo.png
  2. replace those references with a reference equivalent to https://raw.githubusercontent.com/mkevenaar/chocolatey-packages/master/icons/crystaldiskinfo.png
mkevenaar commented 1 year ago

Hey Jeroen,

Bedankt!

if you want, you could submit a PR to replace the file in the repo. Keep the filename and case the same and the scripts should automagically pick it up when there is a newer version of the software.

jpluimers commented 1 year ago

Will do shortly.

jpluimers commented 1 year ago

Done. Please let me know if shortened pull-request like these are OK for you.