Initial try for `crystaldiskmark.portable`, related: #159

jpluimers commented 1 year ago

New package based on the notes in https://github.com/mkevenaar/chocolatey-packages/issues/159 including the various documentation bits (crystaldiskmark.png, crystaldiskmark.portable.md. README.md, LICENSE.txt (placeholder), VERIFICATION.txt and crystaldiskinfo.portable.nuspec).

Please give it a thorough code review as this is my first new package ever.

Description

New package crystaldiskmark.portable

Motivation and Context

There is no crystaldiskmark.portable package yet.

Not sure if it is indeed fixed.

Related: #159

How Has this Been Tested?

Ran individual lines of update.ps1 to test intermediate variable contents.
Verified all hard-coded URLs in all the scripts for existence
Visual inspection of the rendering of the Markdown files.
Recursive diff using Beyond Compare against the crystaldiskinfo.portable related files.

Screenshot (if appropriate, usually isn't needed):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[X] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[X] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[X] I have updated the package description and it is less than 4000 characters.
[X] All files are up to date with the latest Contributing Guidelines (that Markdown file is huge, so I hopefully have not skipped bits while reading it)
[ ] The added/modified package passed install/uninstall in the chocolatey test environment. (not sure how to setup that environment: need guidance with that)
[X] The changes only affect a single package (not including meta package).

AppVeyorBot commented 1 year ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 1 year ago

@jpluimers before going into full review mode, how is this package different compared to https://community.chocolatey.org/packages/crystaldiskmark ?

mkevenaar commented 1 year ago

No response after a month, closing PR. Package already exists

mkevenaar / chocolatey-packages