(iobit-uninstaller) Add '/NoDesktopIcon' package parameter

slycordinator commented 1 year ago

Allows for disabling desktop icon/shortcut

Description

Sets the /MERGETASKS parameter that iobit-uninstaller uses for the desktop icon task If '/NoDesktopIcon' is not set:

/MERGETASKS='destkopicon' If '/NoDesktopIcon' is set:
/MERGETASKS='!destkopicon'

Motivation and Context

Allows to disable/enable the desktop icon. Some people dislike having their desktop cluttered by these thing.

How Has this Been Tested?

I've installed the package several times, finding it worked. And it's had no effect on the program; it's just a change related to the icon. Though, I haven't done this in the test environment. I'm currently on a computer that I can't get the test environment to work on.

Screenshot (if appropriate, usually isn't needed):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the code style of this repository.
[X] My change requires a change to documentation (this usually means the notes in the description of a package).
[X] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[X] I have updated the package description and it is less than 4000 characters.
[X] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[X] The changes only affect a single package (not including meta package).

AppVeyorBot commented 1 year ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

slycordinator commented 1 year ago

It seems that it's failing the tests because the uninstaller isn't silent; the artifacts show the program's GUI popup.

I see online that to uninstall the program silently, the uninstaller exe needs to be supplied the arguments '/VERYSILENT /NORESTART /DetainUninstall'

Though, that's a separate issue from adding the package parameter. I'll try to work up a fix for that as well and make a separate PR for it.

AppVeyorBot commented 1 year ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 1 year ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

mkevenaar commented 1 year ago

@slycordinator could you please rebase this and solve the merge conflict?

slycordinator commented 1 year ago

@slycordinator could you please rebase this and solve the merge conflict?

It's been rebased. :)

AppVeyorBot commented 1 year ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 1 year ago

@slycordinator Your changes have been merged, thank you for your contribution

mkevenaar / chocolatey-packages