mkevenaar / chocolatey-packages

My chocolatey packages
https://mkevenaar.github.io/chocolatey-packages/
Apache License 2.0
42 stars 70 forks source link

(googledrive) Add package parameter to skip application launch after installation #192

Closed brogers5 closed 1 year ago

brogers5 commented 1 year ago

Description

This changeset adds an additional install argument to googledrive's silent arguments, which will prevent Google Drive's installer from automatically starting Google Drive after install.

Motivation and Context

Fixes #190.

--skip_launch_new (as documented in this help article) will prevent Google Drive from automatically starting post-installation. IMO, this would be a better solution than the proposed idea of scripting a window closure post-install, as this behavior could be overridden without requiring a package parameter that modifies the install script's behavior.

How Has this Been Tested?

Environments

Dev

Chocolatey Test Environment

Steps

  1. Created a test package of the current version that consumes the modified scripts (i.e. choco pack).
  2. In my Chocolatey Test Environment instance, Installed the test package (i.e. choco install googledrive --source="'.'").
  3. Confirmed the package installation succeeds without errors.
  4. Confirmed Google Drive is NOT launched by the installer.

Screenshot (if appropriate, usually isn't needed):

N/A

Types of changes

Checklist:

AppVeyorBot commented 1 year ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 1 year ago

@brogers5 What if the user wants to keep the existing functionality? I prefer not to change the existing functionality and add this as an optional parameter. Could you please change that?

soredake commented 1 year ago

What if the user wants to keep the existing functionality?

I am (as a user) think that silent install should be really silent, with no windows, but others might not agree.

AppVeyorBot commented 1 year ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

brogers5 commented 1 year ago

While I'm inclined to agree with @soredake's take on this, it seems avoiding a potentially breaking change for current package consumers takes priority.

I've added a /NoStart package parameter which should append this argument.