Closed brogers5 closed 1 year ago
:white_check_mark: Package verification completed without issues. PR is now pending human review
@brogers5 What if the user wants to keep the existing functionality? I prefer not to change the existing functionality and add this as an optional parameter. Could you please change that?
What if the user wants to keep the existing functionality?
I am (as a user) think that silent install should be really silent, with no windows, but others might not agree.
:white_check_mark: Package verification completed without issues. PR is now pending human review
While I'm inclined to agree with @soredake's take on this, it seems avoiding a potentially breaking change for current package consumers takes priority.
I've added a /NoStart
package parameter which should append this argument.
Description
This changeset adds an additional install argument to
googledrive
's silent arguments, which will prevent Google Drive's installer from automatically starting Google Drive after install.Motivation and Context
Fixes #190.
--skip_launch_new
(as documented in this help article) will prevent Google Drive from automatically starting post-installation. IMO, this would be a better solution than the proposed idea of scripting a window closure post-install, as this behavior could be overridden without requiring a package parameter that modifies the install script's behavior.How Has this Been Tested?
Environments
Dev
Chocolatey Test Environment
Steps
choco pack
).choco install googledrive --source="'.'"
).Screenshot (if appropriate, usually isn't needed):
N/A
Types of changes
Checklist: