search

mkevenaar / chocolatey-packages

My chocolatey packages
https://mkevenaar.github.io/chocolatey-packages/
Apache License 2.0
42 stars 70 forks source link

(gitkraken) needlessly downloads the setup if it's been updated already #202

Closed corbob closed 2 weeks ago

corbob commented 1 year ago

Expected Behavior

When installing or upgrading the GitKraken Chocolatey package, I would like it to detect if the version (or greater) is already installed and no-op if it is.

Current Behavior

GitKraken has a habit of keeping itself upgraded on it's own. This will often result in having a newer version installed than the Chocolatey Package. When you go to upgrade the Chocolatey package, it will download the GitKraken setup, and run it. This results in needlessly downloading a 200+ MB file, as well as closing the GitKraken client by setup.exe.

Possible Solution

I believe the vscode among a few other packages have checks for versions, so we could look to those examples and adjust for GitKraken. There is also this PR for adding a similar check to Slack.

Steps to Reproduce (for bugs)

  1. Install GitKraken 9.6.0 Chocolatey package
  2. Let GitKraken upgrade itself
  3. Perform choco upgrade gitkraken while GitKraken is running
  4. Note that the setup.exe is downloaded, as well as GitKraken closing.

Context

I think this has been provided above, but I can expand if needed. I am also willing to contribute a PR to address this request.

Your Environment

mkevenaar commented 1 year ago

Hi @corbob

Are you willing to submit a PR for this?

Thanks

corbob commented 1 year ago

@mkevenaar absolutely. I'll take a look at it in the next week or so.

corbob commented 1 month ago

I absolutely thought I had provided a PR for this... but evidently I have not. The plot has thickened slightly since this was opened: GitKraken Desktop is now served from a different URL, it is now https://release.axocdn.com/windows/GitKrakenSetup.exe instead of https://release.gitkraken.com/win64/GitKrakenSetup.exe. It also appears on https://www.gitkraken.com/download that there is no longer a 32 bit version available. I have reached out to GitKraken regarding both of these, and will do up a PR once I hear from them, and can tie it to this issue.

corbob commented 1 month ago

It looks like the URL was changed with the 9.11.0 release, as 9.10.0 is the last version before December 1, 2023. And when you install it on 32 bit Windows, you get this notification: image