fixes #206 - zabbix agent needs to stop the service if it detects it present

anthonysomerset commented 9 months ago

Revert Zabbix Agent install to use the .install package and msi rather than extract zip which fails because of things like managing services - Fixes #206

Description

reverts https://github.com/mkevenaar/chocolatey-packages/commit/175d1d81772859d1a2836c97a980cac1761f30dc to restore the previously working upgrade functionality for zabbix agent versions

Motivation and Context

fixes zabbix agent upgrades that are failing because extracting zip cannot succeed without doing things like stopping the service first

How Has this Been Tested?

Screenshot (if appropriate, usually isn't needed):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

AppVeyorBot commented 9 months ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 9 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

anthonysomerset commented 9 months ago

apologies i got the change wrong - don't think the commit needs reverting - just hopefully a service stop if present

mkevenaar commented 8 months ago

@anthonysomerset thank you for your contribution, your changes have been merged

mkevenaar / chocolatey-packages