mkevenaar / chocolatey-packages

My chocolatey packages
https://mkevenaar.github.io/chocolatey-packages/
Apache License 2.0
43 stars 76 forks source link

Update GitKraken package #262

Closed corbob closed 2 months ago

corbob commented 2 months ago

Description

Update the GitKraken package to:

  1. Remove the 32 bit download at GitKraken no longer provides a 32 bit version.
  2. Update the ChocolateyInstall script to detect if GitKraken is already updated, and if it is, do not install the update.

Note about the change: The version detection in the package does not take into account any date fix versioning, so it will see 10.3.0 installed as being outdated if for instance the package is pushed with a date fix version of 10.3.0.20240905. This would be the same as the existing behaviour, so it seems reasonable to me.

Motivation and Context

The GitKraken installer forcibly closes any open GitKraken windows, even if it doesn't need to update anything.

How Has this Been Tested?

  1. Set the GitKraken version in the nuspec to 10.2.1
  2. Ran ./update.ps1 in the GitKraken directory to ensure it updated the GitKraken package.
  3. Ran choco upgrade gitkraken -s . to verify that my local GitKraken did not update the already up to date GitKraken.

Screenshot (if appropriate, usually isn't needed):

Types of changes

Checklist:

AppVeyorBot commented 2 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 2 months ago

@corbob your changes have been merged. Thank you for your contribution!