googledrive: add /NoDesktopIcon parameter

omarali commented 1 month ago

(googledrive) add /NoDesktopIcon parameter

Description

Add /NoDesktopIcon parameter to disable creation of a google drive desktop shortcut.

Installing Google Drive without creating any desktop shortcuts.

Testing the flag itself

Tested that running GoogleDriveSetup.exe with "--silent" does not create a desktop shortcut.
Tested that running GoogleDriveSetup.exe with "--silent --desktop_shorcut=false" does not create a desktop shortcut.
Tested that running GoogleDriveSetup.exe with "--silent --desktop_shorcut=true" creates a desktop shortcut.
Tested that running GoogleDriveSetup.exe with "--silent --desktop_shorcut" creates a desktop shortcut.

Testing the package Ran choco pack then installed the package:

without any params, a Google Drive shortcut is created and the Gsuite shortcuts are created.
with /NoDesktopIcon param, a Google Drive shortcut was not created but the Gsuite shortcuts are created.
with /NoDesktopIcon and /NoGsuiteIcons params, no shortcuts are created.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

[x] My code follows the code style of this repository.
[x] My change requires a change to documentation (this usually means the notes in the description of a package).
[x] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[x] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

AppVeyorBot commented 1 month ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

mkevenaar commented 1 month ago

@omarali your changes have been merged. Thank you for your contribution. This will be included in the next release of Google Drive