mkhahani / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Android.mk missing required src files, compiler flag. #639

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In order to get Breakpad to compile for me (under NDK r10d) I had to add this 
flag:

+LOCAL_CXXFLAGS := -fno-strict-aliasing

and these these src files:

+    src/client/linux/dump_writer_common/seccomp_unwinder.cc \
+    src/client/linux/dump_writer_common/thread_info.cc \
+    src/client/linux/dump_writer_common/ucontext_reader.cc \
+    src/client/linux/microdump_writer/microdump_writer.cc \

to Android.mk.  This is not a big deal, but it would be nice if it worked out 
of the box.

The "strict-aliasing" flag is necessary to handle some type punning inside 
md5.cc.  It would be great to just change that to a memcpy, but I didn't have a 
simple way to test it so I opted for the flag :)

Original issue reported on code.google.com by pline...@gmail.com on 19 Feb 2015 at 6:12