search

mkhairi / materialize-sass

Materializecss rubygem for Rails Asset Pipeline / Sprockets
http://materialize.labs.my/
MIT License
805 stars 243 forks source link

Adding turbolinks:load to document.on('ready') #108

Closed abreckner closed 7 years ago

abreckner commented 8 years ago

Hello, I forked your excellent project to get it working with turbolinks and I thought I would create a pull request in case you wanted to merge it in.

I did try using the jquery.turbolinks gem, but I believe it had some problems with the module pattern used to instantiate the forms (in forms.js). Specifically https://github.com/kossnocorp/jquery.turbolinks#events-firing-twice-or-more

In any case, I will be using my fork for now. Please let me know if you do merge it in as I would much prefer to be using the source.

Thanks very much

Tony Breckner

jameswilliamiii commented 8 years ago

Thanks for taking the time to make these changes. Hopefully these gets merged in soon.

rubendinho commented 8 years ago

Is this for Turbolinks 5?

abreckner commented 7 years ago

Hi, Sorry, I only just saw these comments. Yes, this is for Turbolinks 5

rubendinho commented 7 years ago

It looks like similar changes got added and then removed in a following commit. Not sure why though.