search

mkharibalaji / react-native-adyen-payment

React Native Adyen Payment
https://mkharibalaji.github.io/react-native-adyen-payment/
MIT License
35 stars 35 forks source link

🐛 Avoid app crash when iDeal is refused on Android #51

Closed Gp2mv3 closed 3 years ago

Gp2mv3 commented 3 years ago

Checks that refusalReasonCode is given. If it's not, the app crashes when using getString("refusalReasonCode") without this verification.

ChielBruin commented 3 years ago

Seems do fix the same issue as #46, but in a different way

Gp2mv3 commented 3 years ago

Yep, I saw it just after pushing my PR.

I think both works as efficiently: Mine checks the existence of the field, #46 checks the nullity of the field.

FYI: I use my PR in production for some months without any issue.

mickadoua commented 3 years ago

Hi @Gp2mv3 @ChielBruin do you know how we can contribute more easly on this repo ? this seems dead for a couple of months now,

ChielBruin commented 3 years ago

@mickadoua I will send @mkharibalaji a quick email, maybe he will respond to that