rinsa318
commented
3 months ago Sorry for the messy code, but it can be improved by saving it in session_state like this.
class AuthenticationModel:
"""
This class executes the logic for the login, logout, register user, reset password,
forgot password, forgot username, and modify user details widgets.
"""
def __init__(
self,
credentials: dict,
pre_authorized: Optional[List[str]] = None,
validator: Optional[Validator] = None,
auto_hash: bool = True,
):
"""
Create a new instance of "AuthenticationService".
Parameters
----------
credentials: dict
Dictionary of usernames, names, passwords, emails, and other user data.
pre-authorized: list, optional
List of emails of unregistered users who are authorized to register.
validator: Validator, optional
Validator object that checks the validity of the username, name, and email fields.
auto_hash: bool
Automatic hashing requirement for the passwords,
True: plain text passwords will be automatically hashed,
False: plain text passwords will not be automatically hashed.
"""
self.credentials = credentials
if "AuthenticationService.__init__.usernames" not in st.session_state:
st.session_state["AuthenticationService.__init__.usernames"] = None
if "AuthenticationService.__init__.auto_hash" not in st.session_state:
st.session_state["AuthenticationService.__init__.auto_hash"] = None
if self.credentials["usernames"]:
# convert usernames
if st.session_state["AuthenticationService.__init__.usernames"] is None:
print("convert username")
self.credentials["usernames"] = {
key.lower(): value for key, value in self.credentials["usernames"].items()
}
st.session_state["AuthenticationService.__init__.usernames"] = self.credentials["usernames"]
else:
print("load userneme from session state")
self.credentials["usernames"] = st.session_state["AuthenticationService.__init__.usernames"]
if auto_hash:
# hash password
if st.session_state["AuthenticationService.__init__.auto_hash"] is None:
print("hash password")
if len(self.credentials["usernames"]) > params.AUTO_HASH_MAX_USERS:
print(
f"""Auto hashing in progress. To avoid runtime delays, please manually
pre-hash all plain text passwords in the credentials using the
Hasher.hash_passwords function, and set auto_hash=False for the
Authenticate class. For more information please refer to
{params.AUTO_HASH_MAX_USERS_LINK}."""
)
hashed_pw = {}
for username, _ in self.credentials["usernames"].items():
if not Hasher._is_hash(self.credentials["usernames"][username]["password"]):
self.credentials["usernames"][username]["password"] = Hasher._hash(
self.credentials["usernames"][username]["password"]
)
hashed_pw[username] = self.credentials["usernames"][username]["password"]
st.session_state["AuthenticationService.__init__.auto_hash"] = hashed_pw
else:
print("load hased password from session state")
hashed_pw = st.session_state["AuthenticationService.__init__.auto_hash"]
for username, _ in self.credentials["usernames"].items():
self.credentials["usernames"][username]["password"] = hashed_pw[username]
else:
self.credentials["usernames"] = {}
self.pre_authorized = pre_authorized
self.validator = validator if validator is not None else Validator()
if "name" not in st.session_state:
st.session_state["name"] = None
if "authentication_status" not in st.session_state:
st.session_state["authentication_status"] = None
if "username" not in st.session_state:
st.session_state["username"] = None
if "logout" not in st.session_state:
st.session_state["logout"] = None
def check_credentials(
ocmarus
mkhorasani
First of all, thanks for the great library!
I noticed that v0.3.3 fails to authenticate if the username contains uppercase letters. So I read the code in detail and noticed that the credential initialization was being overwritten each time( L45, in authentication_model.py ) . Therefore, I feel that 'AuthenticationService.init' was not working as you expected.